Skip to content

feat: Expose HRQ limit and usage on metrics endpoint. #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 20, 2025
Merged

feat: Expose HRQ limit and usage on metrics endpoint. #30

merged 4 commits into from
Oct 20, 2025

Conversation

@ryotarai
Copy link
Collaborator

@ryotarai ryotarai commented Sep 16, 2025

This exposes HRQ limit and usage on the metrics endpoint.

The metric labels align with kube_resourcequota metric of kube-state-metrics.

$ curl --silent localhost:8080/metrics | grep hnc_hierarchicalresourcequota
# HELP hnc_hierarchicalresourcequota HRQ hard/used like kube_resourcequota
# TYPE hnc_hierarchicalresourcequota gauge
hnc_hierarchicalresourcequota{hrq="test-a",namespace="test-parent",resource="cpu",type="hard"} 20
hnc_hierarchicalresourcequota{hrq="test-a",namespace="test-parent",resource="cpu",type="used"} 0
hnc_hierarchicalresourcequota{hrq="test-a",namespace="test-parent",resource="memory",type="hard"} 4.294967296e+10
hnc_hierarchicalresourcequota{hrq="test-a",namespace="test-parent",resource="memory",type="used"} 0

@ryotarai ryotarai marked this pull request as ready for review September 16, 2025 00:37
@superbrothers
Copy link
Member

superbrothers commented Sep 16, 2025

  • Please document metrics in HRQ's documentation.
  • Please verify that the hnc_ prefix for metric names aligns with the existing metric prefix.

@ryotarai
Copy link
Collaborator Author

ryotarai commented Oct 1, 2025 

$ curl --silent localhost:8080/metrics | grep -v ^# | cut -d'_' -f1 | sort | uniq 
certwatcher
controller
go
hnc
process
rest
workqueue

$ curl --silent localhost:8080/metrics | grep ^hnc_   
hnc_namespace_conditions{Condition="ActivitiesHalted",Reason="AncestorHaltActivities"} 0
hnc_namespace_conditions{Condition="ActivitiesHalted",Reason="DeletingCRD"} 0
hnc_namespace_conditions{Condition="ActivitiesHalted",Reason="IllegalManagedAnnotation"} 0
hnc_namespace_conditions{Condition="ActivitiesHalted",Reason="IllegalManagedLabel"} 0
hnc_namespace_conditions{Condition="ActivitiesHalted",Reason="IllegalParent"} 0
hnc_namespace_conditions{Condition="ActivitiesHalted",Reason="InCycle"} 0
hnc_namespace_conditions{Condition="ActivitiesHalted",Reason="ParentMissing"} 0
hnc_namespace_conditions{Condition="BadConfiguration",Reason="SubnamespaceAnchorMissing"} 0
hnc_reconcilers_hierconfig_concurrent_peak 0
hnc_reconcilers_hierconfig_namespace_writes_total 62
hnc_reconcilers_hierconfig_total 22
hnc_reconcilers_object_concurrent_peak{GroupKind=""} 0
hnc_reconcilers_object_total{GroupKind=""} 8

@superbrothers
Copy link
Member

superbrothers commented Oct 6, 2025

@utam0k Could you please take a look at this PR?

utam0k
utam0k reviewed Oct 6, 2025
View reviewed changes
@ryotarai ryotarai requested a review from utam0k October 16, 2025 13:22
utam0k
utam0k approved these changes Oct 20, 2025
View reviewed changes
Copy link
Member

@utam0k utam0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@utam0k utam0k merged commit e88557e into pfnet:master Oct 20, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@superbrothers superbrothers superbrothers approved these changes

@utam0k utam0k utam0k approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ryotarai @superbrothers @utam0k